Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: after slicing name trim to remove whitespace #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

coreyar
Copy link

@coreyar coreyar commented May 27, 2024

Original Updated Change Reasoning
scripts/pull_from_dune.py n/a strip white space after slicing name prevents extra underscore between query name and query id

Provide any other context or screenshots that explain or justify the changes above:

If the sliced name ends in white space replacing whitespace with underscores will add an extra underscore at the end of the file which can cause issues when prasing for the query id


Note to Contributor:

Make sure your PR edits the original query_id.sql file with the new query text. If you are proposing adding a new query completely, make sure to add it to queries.yml and as a file in /queries as well.

Thanks for contributing! 🙏

If the sliced name ends in white space replacing whitespace with underscores
will add an extra underscore at the end of the file which can cause issues
when prasing for the query id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant