fix: after slicing name trim to remove whitespace #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scripts/pull_from_dune.py
Provide any other context or screenshots that explain or justify the changes above:
If the sliced name ends in white space replacing whitespace with underscores will add an extra underscore at the end of the file which can cause issues when prasing for the query id
Note to Contributor:
Make sure your PR edits the original
query_id.sql
file with the new query text. If you are proposing adding a new query completely, make sure to add it toqueries.yml
and as a file in/queries
as well.Thanks for contributing! 🙏