Add firebase/php-jwt v7.* support to fix CVE-2025-45769 #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@AaronAtDuo what are your thoughts on this? |
Contributor
|
Thank you for notifying us of this issue! We have just merged in #24 , which allows support for both 6.X and 7.X versions of firebase/php-jwt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The package
firebase/php-jwtcontains CVE-2025-45769 security vulnerability and only fixed in version 7. This library depends on v6 and require support for v7 as well.Motivation and Context
Security issue.
How Has This Been Tested?
Via unit test. It's failing BTW because major changes in the php-jwt package.
Types of Changes
The test cases are failing with
Provided key is too shorterror. And upon checking the client secret length is what is recommended. I think package needs a major version bump with only v7. If you agree I can update PR to remove v6 requirements.