Skip to content

bucket: ensure Bucket::exists() honours 'dangereous' config #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2025
Merged

bucket: ensure Bucket::exists() honours 'dangereous' config #415

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec28212
bucket: ensure Bucket::exists() honours 'dangereous' config
whitty Feb 22, 2025
997b9de
Update s3/src/bucket.rs
durch Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions s3/src/bucket.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,16 @@ impl Bucket {
credentials: Credentials,
) -> Result<crate::bucket_ops::ListBucketsResponse, S3Error> {
let dummy_bucket = Bucket::new("", region, credentials)?.with_path_style();
let request = RequestImpl::new(&dummy_bucket, "", Command::ListBuckets).await?;
dummy_bucket.list_buckets_().await
}

/// Internal helper method that performs the actual bucket listing operation.
/// Used by the public `list_buckets` method to retrieve the list of buckets for the configured client.
#[maybe_async::maybe_async]
async fn list_buckets_(
&self
) -> Result<crate::bucket_ops::ListBucketsResponse, S3Error> {
let request = RequestImpl::new(self, "", Command::ListBuckets).await?;
let response = request.response_data(false).await?;

Ok(quick_xml::de::from_str::<
Expand Down Expand Up @@ -479,9 +488,10 @@ impl Bucket {
/// ```
#[maybe_async::maybe_async]
pub async fn exists(&self) -> Result<bool, S3Error> {
let credentials = self.credentials().await?;
let mut dummy_bucket = self.clone();
dummy_bucket.name = "".into();

let response = Self::list_buckets(self.region.clone(), credentials).await?;
let response = dummy_bucket.list_buckets_().await?;

Ok(response
.bucket_names()
Expand Down