Skip to content

Allow requesting specific job attributes #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow requesting specific job attributes #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23946eb
Add configurable job attribute names
tepeds Aug 26, 2019
5093c7d
Use pop specific configuration item names
tepeds Aug 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 40 additions & 3 deletions src/Sqs/Queue.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,14 @@ public function pop($queue = null)
{
$queue = $this->getQueue($queue);

$response = $this->sqs->receiveMessage([
$options = [
'QueueUrl' => $queue,
'AttributeNames' => ['ApproximateReceiveCount'],
]);
];

$options = $this->addAttributeNames($options);
$options = $this->addMessageAttributeNames($options);

$response = $this->sqs->receiveMessage($options);

if (isset($response['Messages']) && count($response['Messages']) > 0) {
$queueId = explode('/', $queue);
Expand All @@ -80,6 +84,39 @@ public function pop($queue = null)
}
}

private function addAttributeNames($options)
{
$list = Config::get('sqs-plain.popAttributeNames', '');
$names = array_merge(['ApproximateReceiveCount'], explode(',', $list));

$options['AttributeNames'] = $this->cleanArray($names);

return $options;
}

private function addMessageAttributeNames($options)
{
$list = Config::get('sqs-plain.popMessageAttributeNames', '');

if (empty($list)) {
return $options;
}

$names = explode(',', $list);

$options['MessageAttributeNames'] = $this->cleanArray($names);

return $options;
}

private function cleanArray($array)
{
$array = array_map('trim', array_filter($array));
$array = array_unique($array);

return $array;
}

/**
* @param string|array $payload
* @param string $class
Expand Down