Fix position of comments #297
Conversation
go-fuzz-build/cover.go
Outdated
| if p1 < p2 { | ||
| return p1 | ||
| } else { | ||
| return p1 |
There was a problem hiding this comment.
This always returns p1.
There was a problem hiding this comment.
Thanks! Looks like this is not really related since it's not breaking compilation.
There was a problem hiding this comment.
Which also means we don’t need min at all—instead of fixing min, you could have replaced it in all places with its first arg. That makes me a bit nervous that maybe we still don’t fully understand the fix that is needed. I’d love to see some tests, or at the least a bit of explanation somewhere. Also, why the constant 1? (Why not 0? Why not some other nearby position?) Again, tests or docs would be great.
There was a problem hiding this comment.
You're right. So far this pr is only a POC for my current fuzzing project. I neither fully understand this but it seems to be working (or more lucky, correct) and I will try to understand and refine it later.
I use the const 1 just for simplicity, 0 didn't work for it's a special value token.NoPos = 0 in go.
There was a problem hiding this comment.
Sounds good. I really appreciate you taking the time to investigate it. I hope go-fuzz is yielding good results for you.
|
Can this be closed now? |
|
Superseded by #306 |
closes #294