Skip to content

Add spdlog #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arcondello merged 8 commits into from
Dec 19, 2022
Merged

Add spdlog #71

arcondello merged 8 commits into from
Dec 19, 2022

Conversation

@mdcoury
Copy link
Contributor

@mdcoury mdcoury commented Dec 11, 2022

No description provided.

@arcondello
Copy link
Member

arcondello commented Dec 12, 2022

We should rename .h to .hpp, but technically that's a backwards compatibility break, so it will need to wait for Ocean 7. Also, you'll need to add spdlog to MANIFEST.in. See #55 for an example.

@mdcoury mdcoury changed the title Add logging Add spdlog Dec 15, 2022
@arcondello arcondello mentioned this pull request Dec 19, 2022
Open
@arcondello arcondello merged commit dcdec35 into dwavesystems:main Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdcoury @arcondello