This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 326
16 colors #662
Open
eylles
wants to merge
10
commits into
dylanaraps:master
Choose a base branch
from
eylles:16_cols
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
16 colors #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… colors.py, that makes pywal generate darker shades for 1-7
…s, and alacritty output templates.
these should be their own PR
this separation should be done in other way, not with dirs.
now the default behaviour is 9 colors again, and 16 colors is a flag
Great work on this @eylles! I really appreciate you mentioning me and adding me as collaborator. I really hope this is going to get merged! |
Welp, @sonjiku your work was the original PR, if it doesn't get merged even after this, what do u say about we collaborate on a more permanent fork? All we need is a name and to add the package to pip. |
welp, i may be a bit too impatient but will start to work on a branch to merge some stuff from PRs and perhaps prepare a repo maybe call it pywal16 ? |
welp, created a detached repo with my branch from this pr as master branch, will start merging some of the open PRs of pywal over there. |
the names used to be backwards with a 9 being added to 16 color themes and visceversa.
somehow the fork still lives https://pypi.org/project/pywal16/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the heavy work for this PR was done by sonjiku in #601, this PR is a clean up of that one in hopes that the this will be merged now that all the possible reasons as to why #601 wasn't getting merged have been adressed.