Skip to content

Conversation

@marioserrano09
Copy link
Contributor

This pull request introduces a new release (version 3.4.3) across all modules and significantly extends the AccountPaymentDTO data transfer object to support more payment-related attributes. It also updates the AccountPayment entity to ensure all new DTO fields are properly populated, and refines some UI action properties for better clarity and consistency.

DTO and Entity Enhancements:

  • Added multiple new fields to AccountPaymentDTO (such as account, paymentMethod, couponCode, externalReference, invoiceNumber, reseller, etc.) to capture more detailed payment information. Corresponding getters and setters were implemented. [1] [2] [3] [4]
  • Updated AccountPayment entity's toDTO() method to populate all new DTO fields, ensuring that related entity data (like payment method, additional service, account, and reseller) is transferred to the DTO.

Project Version Updates:

  • Bumped the version from 3.4.2 to 3.4.3 in all Maven pom.xml files across the project, including parent, API, core, JPA, remote, and UI modules, to mark the new release and ensure dependency consistency. [1] [2] [3] [4] [5] [6] [7] [8] [9]

UI Improvements:

  • Updated the NewAccountPaymentAction UI action to use setShowLabel(true) instead of setting the attribute directly, removed deprecated color/background settings, and set the action type to "success" for better semantic clarity.

Code Cleanup:

  • Refactored imports in AccountPayment.java for clarity and to remove unused wildcard imports.

These changes collectively enhance the extensibility and maintainability of the payment module, provide richer data transfer capabilities, and ensure the UI and project structure are up to date with the latest standards.

Copilot AI review requested due to automatic review settings September 5, 2025 14:19
@marioserrano09 marioserrano09 merged commit 6324378 into master Sep 5, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces version 3.4.3 across all modules and significantly enhances the AccountPaymentDTO to support more comprehensive payment information, improving data transfer capabilities for payment-related operations.

  • Updated all module versions from 3.4.2 to 3.4.3 for consistency
  • Extended AccountPaymentDTO with multiple new fields for detailed payment tracking
  • Implemented toDTO() method in AccountPayment entity to populate new DTO fields

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sources/pom.xml Updated parent module version to 3.4.3
sources/api/pom.xml Updated API module version to 3.4.3
sources/core/pom.xml Updated core module version and dependencies to 3.4.3
sources/jpa/pom.xml Updated JPA module version and dependencies to 3.4.3
sources/remote/pom.xml Updated remote module version and dependencies to 3.4.3
sources/ui/pom.xml Updated UI module version to 3.4.3
sources/api/src/main/java/tools/dynamia/modules/saas/api/dto/AccountPaymentDTO.java Added extensive new fields and getters/setters for enhanced payment data
sources/core/src/main/java/tools/dynamia/modules/saas/domain/AccountPayment.java Refactored imports and implemented toDTO() method with proper field mapping
sources/ui/src/main/java/tools/dynamia/modules/saas/ui/action/NewAccountPaymentAction.java Updated action configuration with modern API usage

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +413 to +417
}


return dto;
}
Copy link

Copilot AI Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Remove the extra blank line at line 415 to maintain consistent spacing in the method.

Suggested change
}
return dto;
}
}
return dto;
}

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants