Skip to content

Conversation

@rica-carv
Copy link
Contributor

@rica-carv rica-carv commented Oct 6, 2024

Motivation and Context

Top.php updated to use forum templates, instead of hardcoded HTML
Hardcoded HTML is still in file for use when template is not available...

Description

Updated top.php to use the newforumposts template
Work in progress...
The top.php file is merging several plugins, so i ask why not use a top.php file in every plugin instead of a common one?

How Has This Been Tested?

Tested in v.2.3.3

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit e08c9b3 and detected 6 issues on this pull request.

Here's the issue category breakdown:

Category Count
Bug Risk 6

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 48.9% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant