Skip to content

Conversation

@rica-carv
Copy link
Contributor

Motivation and Context

Enable passthrough of parms from the USER_SENDPM shortcode in user plugin to the SENDPM shortcode in e_shortcode

Description

Corrected issue when parms where sent to the USER_SENDPM shortcode where ignored and never sent through to the SENDPM shortcode

How Has This Been Tested?

Current github e107 code

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist

)
);
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rica-carv I believe this can be replaced with http_build_qry();

$parm = ['key1' => 'value1', 'key2' => 'value2'];
$query_string = http_build_query($parm);
// Output: key1=value1&key2=value2

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit c32a414 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 33.3% (80% is the threshold).

This pull request will bring the total coverage in the repository to 48.9% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants