fix: improve error message when package.json is missing #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
…pshots for consistent output
43081j
reviewed
Nov 10, 2025
|
|
||
| let message = `${severityColor('[duplicate dependency]')} ${colors.bold(duplicate.name)} has ${duplicate.versions.length} installed versions:`; | ||
| // Disable colors completely when NO_COLOR is set (for consistent test snapshots) | ||
| const noColor = process.env.NO_COLOR === '1'; |
Contributor
There was a problem hiding this comment.
why?
this feels like a workaround rather than a necessity.
are you doing this because we didn't have any snapshots yet which use colours? we should just set FORCE_COLOR to 1 in the vitest config env (although vitest 4 might already do this)
Contributor
Author
There was a problem hiding this comment.
indeed it was a workaround cause i couldn't make the tests work properly even after updating the snapshots.
Contributor
|
i think we need to hold off on this change until i finish aligning a bunch of the logic with the e18e github action as it will change quite a lot of the inner workings ill get back to it once i merge that stuff 👍 |
Contributor
Author
|
is there anything i can help you with? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #119