Skip to content

fix: hide ES modules info from summary #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
outslept wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: hide ES modules info from summary #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34342d2
fix: hide ES modules info from summary
outslept Aug 12, 2025
8e9bfd1
chore: revert dependencies file
outslept Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/commands/analyze.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,6 @@ export async function run(ctx: CommandContext<typeof meta.args>) {

const totalDeps =
stats.dependencyCount.production + stats.dependencyCount.development;
const totalDeepDeps = stats.dependencyCount.cjs + stats.dependencyCount.esm;
const esmPercentage =
totalDeepDeps > 0
? Math.floor((stats.dependencyCount.esm / totalDeepDeps) * 100)
: 0;
Comment on lines -87 to -91
Copy link
Contributor

@dreyfus92 dreyfus92 Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it be better to comment the code instead of removing it?

Copy link
Contributor

@43081j 43081j Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think @outslept is going to revisit this and make it show conditionally rather than removing it entirely

const summaryPairs: Array<[string, string]> = [
['Package Name', stats.name],
['Version', stats.version],
Expand All @@ -101,10 +96,6 @@ export async function run(ctx: CommandContext<typeof meta.args>) {
[
'Dependencies',
`${totalDeps} (${stats.dependencyCount.production} production, ${stats.dependencyCount.development} development)`
],
[
'ES Modules',
`${esmPercentage}% (${stats.dependencyCount.esm} ESM, ${stats.dependencyCount.cjs} CJS)`
]
];

Expand Down
2 changes: 0 additions & 2 deletions src/test/__snapshots__/cli.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ exports[`CLI > should display package report 1`] = `
│ Version 1.0.0
│ Install Size 170.0 B
│ Dependencies 1 (1 production, 0 development)
│ ES Modules 0% (0 ESM, 0 CJS)
│
● Results:
│
Expand All @@ -35,7 +34,6 @@ exports[`CLI > should run successfully with default options 1`] = `
│ Version 1.0.0
│ Install Size 170.0 B
│ Dependencies 1 (1 production, 0 development)
│ ES Modules 0% (0 ESM, 0 CJS)
│
● Results:
│
Expand Down