Avoid SyntaxWarning: "is not" with a literal#39
Closed
Flimm wants to merge 1 commit into
Closed
Conversation
The full text of the warning was: SyntaxWarning: "is not" with a literal. Did you mean "!="?
royhodge830
reviewed
Dec 17, 2021
| directories = [] | ||
| for root, dirs, files in natsort.natsorted(os.walk(path, topdown=False)): | ||
| for name in dirs: | ||
| if name[:1] is not '.': |
royhodge830
approved these changes
Dec 17, 2021
royhodge830
left a comment
royhodge830
left a comment
There was a problem hiding this comment.
looks better. lets push forward with the improvements.
| for root, dirs, files in natsort.natsorted(os.walk(path, topdown=False)): | ||
| for name in dirs: | ||
| if name[:1] is not '.': | ||
| if name[:1] != '.': |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The full text of the warning was: