Skip to content

Use official connectRPC library for python env #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthewlouisbrockman wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Use official connectRPC library for python env #1314

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
d3f950d
Migrate Python envd RPC to upstream Connect
matthewlouisbrockman May 6, 2026
2153ec5
Remove legacy Python Connect implementation
matthewlouisbrockman May 6, 2026
6a60552
Merge remote-tracking branch 'origin/main' into python/connect-rpc-mi…
matthewlouisbrockman May 6, 2026
6ec6cc1
Fix CI after removing legacy Connect generator
matthewlouisbrockman May 6, 2026
7121ab9
changeset
matthewlouisbrockman May 6, 2026
47facc0
Document filesystem ENOENT Connect fallback
matthewlouisbrockman May 6, 2026
42b9538
Keep legacy Connect generator source for CodeQL
matthewlouisbrockman May 6, 2026
dcfeb5f
Fix Python Connect RPC timeout and JSON codec regressions
matthewlouisbrockman May 7, 2026
fb122c2
Preserve Python Connect RPC proxy transport
matthewlouisbrockman May 7, 2026
9778cd6
Fix unlimited Connect stream timeout
matthewlouisbrockman May 7, 2026
1348a4f
Fix Connect stream timeout handling
matthewlouisbrockman May 7, 2026
02ad04a
Handle filesystem Connect not found errors
matthewlouisbrockman May 7, 2026
dd8b25f
Preserve stream request timeout handling
matthewlouisbrockman May 7, 2026
9c9b6f0
Cover Connect RPC adapter edge cases
matthewlouisbrockman May 7, 2026
871e932
Avoid protobuf runtime major bump
matthewlouisbrockman May 7, 2026
cdbbd95
Restore transient RPC protocol retries
matthewlouisbrockman May 7, 2026
6a21bbb
Mark generated envd Python RPC files
matthewlouisbrockman May 7, 2026
0a551a1
Clarify pyqwest HTTPX adapter naming
matthewlouisbrockman May 7, 2026
9d667ba
Tighten Connect RPC adapter timeout semantics
matthewlouisbrockman May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/young-onions-cut.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@e2b/python-sdk': minor
---

Changes the connectrpc implementation to use the official plugin instead
4 changes: 0 additions & 4 deletions codegen.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ RUN go install github.com/bufbuild/buf/cmd/buf@v1.50.1 && \
go install google.golang.org/protobuf/cmd/protoc-gen-go@v1.28.1 && \
go install connectrpc.com/connect/cmd/protoc-gen-connect-go@v1.18.1

# Install our custom protoc plugin, connect-python
COPY ./packages/connect-python /packages/connect-python
RUN cd /packages/connect-python && make bin/protoc-gen-connect-python


FROM python:3.10

Expand Down
4 changes: 0 additions & 4 deletions packages/python-sdk/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ generate-volume-api:
ruff format .

generate-envd:
if [ ! -f "/go/bin/protoc-gen-connect-python" ]; then \
$(MAKE) -C $(ROOT_DIR)/packages/connect-python build; \
fi

cd $(ROOT_DIR)/spec/envd && pwd && buf generate --template buf-python.gen.yaml
./scripts/fix-python-pb.sh

Expand Down
Loading
Loading