Skip to content

Fix pagebreaks bug while first line clientRect.top less than 0 #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix pagebreaks bug while first line clientRect.top less than 0 #340

wants to merge 1 commit into from

Conversation

NKnife
Copy link

@NKnife NKnife commented Aug 13, 2020

If mode include "avoid-all", and first line clientRect.top less than 0, pagebreaks.js will create full page div, make first page empty

test case

// pagebreaks.html
  ...
    <div id="root">
      <p style='margin-top: -10px'>First line</p>
  ...

@Remote-version-git
Copy link

I encounter a problem that img or text content is truncated.
how to solve pagination truncated problem in html2pdf.js?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NKnife @Remote-version-git