Skip to content

Improve controller security, error handling and page layout #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

line-o
Copy link
Member

@line-o line-o commented Aug 2, 2025

  • fixes cross links to documentation apps are broken #16
  • all XQuery modules follow naming conventions
  • page layout improved
    • footer sticks to bottom of the window
    • module info improved (info icon alignment, box margins)
    • function info improved (duplicate function name removed)
  • controller only allows specific routes
  • POST /modules/reindex.xql replaced with GET /regenerate
  • scan.xql rewritten to generate.xqm

-- edit --
The todos in here were misleading. I will open issues with those enhancements we do at some point

Screenshots

Visual differences:
New on the left, old on the right

Screenshot 2025-08-01 at 21 52 59 Screenshot 2025-08-01 at 21 57 16 Screenshot 2025-08-01 at 21 56 37 Screenshot 2025-08-01 at 21 53 35

line-o added 2 commits August 2, 2025 11:04
- footer sticks to the bottom of the window
- improve module info display
  - info icon size and alignment
  - module info boottom and right margin
  - module description foont size
- improve function info display
  - remove duplicate function name
- rewrite scan.xql to generate.xqm
- adhere to naming conventions
- explicitly allow routes and deny evertying else
- route modules/reindex.xql moved to /regenerate
- add routes fro markdown and static resources
- call to /regenerate is a GET request
@line-o line-o requested review from duncdrum and a team August 2, 2025 09:27
@line-o line-o force-pushed the feat/controller-security-error-handling branch from 92297b3 to a4b1876 Compare August 2, 2025 09:31
- use new route `/exist/apps/fundocs/generate`
- do not test for removed headline in function info
- test for changed module name
@line-o line-o force-pushed the feat/controller-security-error-handling branch from a4b1876 to ff5ee89 Compare August 2, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cross links to documentation apps are broken
1 participant