Conversation
dcherian
reviewed
Feb 27, 2026
Comment on lines
+154
to
+156
| actor_name = data.draw(st.sampled_from(list(self.actors.keys()))) | ||
| if actor_name == self.actor_name: | ||
| return |
Collaborator
There was a problem hiding this comment.
Suggested change
| actor_name = data.draw(st.sampled_from(list(self.actors.keys()))) | |
| if actor_name == self.actor_name: | |
| return | |
| actor_name = data.draw(st.sampled_from(list(k for k in self.actors.keys() if k!=self.actor_name))) |
let's just filter it out
Collaborator
Author
|
I actually havve a branch on top of this that goes way farther, and starts allowing for simple rebases with an aribitrary number of actors working in parallel on a repo. so might just swap to that |
- Refactor ClaimTracker: remove _protected, _try_clear, _stash_session, _on_clear - Add delete_dir() and rewrite_manifests() to MultiActorModel - Simplify IcechunkModel with cleaner lifecycle methods - Extract actor logic to multi-actor case only - Fix delete+recreate in rebase (Rust conflict detector) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have reopening logic on the super classes. I wanted to remove the (re)open in the actor switch as that potentially does some re-init which might mask a subtle bug. This way its a bit more like two concurrent actors who have both opened the repo and are doing operations to it.