Design Doc : Add pluggable cache backend#1849
Draft
mpiannucci wants to merge 4 commits into
Draft
Conversation
mpiannucci
changed the title
mpiannucci
commented
Mar 16, 2026
|
|
||
| ### 1. `CacheBackend` Trait | ||
|
|
||
| A new trait abstracts over cache storage. Since external backends require serialized data, **all backends operate on bytes**. Deserialization happens in `AssetManager` on every cache hit. |
Collaborator
Author
There was a problem hiding this comment.
This will introduce a performance hit. The alternative would be a specific cache interface with types specified so in memory could cache everything as full types
mpiannucci
commented
Mar 16, 2026
|
|
||
| **FileCache** (future) — local disk-backed cache using a path on a local filesystem. Config: directory path, max size. | ||
|
|
||
| ### 3. `CachingConfig` — Current State and Evolution |
Collaborator
Author
There was a problem hiding this comment.
This is the biggest area of contention for me: We use quick cache with its specific weighting system and limits but not all cache backends will work with that kind of an interface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See comments for points of specific emphasis
#960