Enable icechunk compilation for wasm32-unknown-emscripten#2065
Draft
mpiannucci wants to merge 1 commit intomainfrom
Draft
Enable icechunk compilation for wasm32-unknown-emscripten#2065mpiannucci wants to merge 1 commit intomainfrom
mpiannucci wants to merge 1 commit intomainfrom
Conversation
Patch backon to allow TokioSleeper on emscripten targets instead of gloo-timers (which requires browser JS APIs unavailable in emscripten). The root issue is that emscripten defaults to panic=unwind, causing wasm-bindgen's MaybeUnwindSafe trait to require UnwindSafe bounds that gloo-timers closures don't satisfy. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
Is there a different library we could use instead? I just picked that one because it looked good. Clearly we have different requirements now. |
Collaborator
Author
|
@dcherian Yeah we can revisit this when i rev on the cache interface |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch backon to allow TokioSleeper on emscripten targets instead of gloo-timers (which requires browser JS APIs unavailable in emscripten). The root issue is that emscripten defaults to panic=unwind, causing wasm-bindgen's MaybeUnwindSafe trait to require UnwindSafe bounds that gloo-timers closures don't satisfy.