Skip to content

handle zarr upstream changes #2076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ianhi wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −22
Open

handle zarr upstream changes #2076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bf07e0
handle zarr upstream changes
ianhi Apr 14, 2026
44a2201
Merge branch 'main' into ian/hypo-debug
ianhi Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions icechunk-python/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,15 @@
from hypothesis import HealthCheck, settings
from mypy_boto3_s3.client import S3Client

import zarr
from icechunk import Repository, SpecVersion, in_memory_storage, local_filesystem_storage

# Zarr may gate rectilinear chunk grids behind a config flag.
# Icechunk supports them, so enable unconditionally for tests.
zarr_has_rectilinear_chunks = "array.rectilinear_chunks" in zarr.config
if zarr_has_rectilinear_chunks:
zarr.config.set({"array.rectilinear_chunks": True})

# ---------------------------------------------------------------------------
# Hypothesis profiles
#
Expand Down
23 changes: 1 addition & 22 deletions icechunk-python/tests/test_zarr/test_stateful.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@
from typing import Any, TypeVar

import hypothesis.strategies as st
import numpy as np
import pytest
from hypothesis import assume, note
from hypothesis import note
from hypothesis.stateful import (
initialize,
invariant,
Expand All @@ -32,10 +31,6 @@
from zarr.testing.stateful import ZarrHierarchyStateMachine, split_prefix_name

PROTOTYPE = default_buffer_prototype()
from zarr.testing.strategies import (
node_names,
np_array_and_chunks,
)

Frequency = TypeVar("Frequency", bound=Callable[..., Any])

Expand Down Expand Up @@ -286,22 +281,6 @@ def shift_array(self, data: st.DataObject) -> None:
self.store.session.shift_array(f"/{array_path}", offset)
self._sync(self.model.shift_array(array_path, offset, num_chunks))

@rule(
data=st.data(),
name=node_names,
array_and_chunks=np_array_and_chunks(),
)
def add_array(
self,
data: st.DataObject,
name: str,
array_and_chunks: tuple[np.ndarray[Any, Any], tuple[int, ...]],
) -> None:
array, _ = array_and_chunks
# TODO: support size-0 arrays GH392
assume(array.size > 0)
super().add_array(data, name, array_and_chunks)

def _compare_list_dir(
self, model: ModelStore, store: ic.IcechunkStore, paths: set[str]
) -> None:
Expand Down
Loading