Skip to content

Conversation

@vickysharma0812
Copy link
Member

This pull request includes updates across multiple modules to improve documentation, enhance functionality, and fix inconsistencies. Key changes include improved comments and metadata, updates to subroutine arguments, and adjustments to procedural implementations for better clarity and maintainability.

Documentation Improvements

  • Added detailed comments and metadata (e.g., author, date, and summary) to several subroutines and functions for better understanding and maintainability. Examples include obj_Initiate8, obj_Initiate9, and to_logical_1 in src/modules/QuadraturePoint/src/QuadraturePoint_Method.F90 and src/modules/String/src/String_Class.F90. [1] [2] [3]

Code Refactoring and Clarifications

  • Updated subroutine argument descriptions to clarify their purpose, such as changing "order of integrand" to "number of quadrature points" in obj_Initiate4 and obj_Initiate10. [1] [2]
  • Improved array slicing and matrix operations in procedures like elemsd_SetBarycentricCoord and elemsd_SetJacobian for better readability and performance in src/submodules/ElemshapeData/src/[email protected]. [1] [2]

Modular Enhancements

  • Introduced new GetPointer interface in src/modules/IntVector/src/IntVector_GetMethod.F90 to provide additional functionality for accessing raw data pointers.
  • Added the to_logical_1 function in src/modules/String/src/String_Class.F90 to extend string-to-logical casting capabilities.

Code Cleanup

  • Reorganized USE statements in ElemshapeData_Method.F90 for better modularity and removed unused dependencies. [1] [2]
  • Replaced .inc file references with .F90 files in src/submodules/IntVector/src/[email protected] for consistency and maintainability.

These changes collectively improve the codebase's clarity, maintainability, and functionality while adhering to best practices.

Adding to_logical_1 to convert string into bool by using to_logical
method.
Now we can get pointer to IntVector by using GetPointer() without any
datatype argument.
Using the range of matrices in methods related to Set1 and Set4.
This is because, we get node coord from mesh, we get the 3 components
even for a 2D problem. It causes some issue in while setting
global element shape data.
@vickysharma0812 vickysharma0812 merged commit d98debf into dev May 31, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants