-
Notifications
You must be signed in to change notification settings - Fork 2
Vikas dev #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Vikas dev #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance the FEVariable module by implementing new getter methods in FEVariable_Method.F90 and its associated submodule. These changes improve the module's API by providing more consistent and robust data access capabilities.
…urePoint_ToInteger interface Make the QuadraturePointNameToId function publicly accessible via the QuadraturePoint_ToInteger interface and add it to the PUBLIC list.
…h case control The FEVariable_ToString function has been renamed to FEVariable_ToChar for consistency with naming conventions. Added an optional 'isUpper' parameter to control text case output. Default output is now in Title Case instead of uppercase, with the ability to convert to uppercase when needed.
- Add explicit allocation check with early return in dof_Display1 - Remove ASSOCIATE block in favor of direct object access - Simplify control flow with more linear structure - Remove "# " prefixes from display messages - Improve code formatting and spacing for readability
- Rename "Elementname" to "ElementName" for consistent capitalization - Update all interface declarations and related comments - Maintain consistent naming conventions across the codebase - Fix lowercase "n" in all occurrences of ElementName in ReferenceElement_Method.F90
Chaning interpol to ans.
Adding vector Interpolation
minor changes in VectorSpaceGetInterpolation_
updates in cmake of FEVariable submodules
adding interpol methods for vector and matrix
Adding Matrix Interpolation Methods
Adding Cmake for Matrix Interpolation Methods
Adding isInit in FEVariable
Adding Master Interpolation methods. Interpolating FEVariable to FEVariable
Adding Master inteprolation, fevariable interpolation into fevariable
updating cmake
Incorporting isInit in FEVariable
adding capacityExpandFactor in FEVariableOpt_
Adding defaultVectorSize and defaultMatrixSize in FEVariableOpt
Adding r1r1r2_ method
Still some routines needs to be updated
Adding a simple massmatrix method
putting include files in include dir with .F90 ext
Updating display method
Adding new mass matrices
- QuadratureVariableMethod is updated for ST Fields
- adding new methods for vectorfield
Updates for STVectorFields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting ready for next version release.
The following summary generated using Copilot.
This pull request introduces several significant improvements and refactorings to the codebase, particularly in the
BaseTypeandBaseInterpolation_Methodmodules. The main changes include a comprehensive cleanup and renaming for consistency, the addition of new parameter types and constants, and enhanced modularity through more granularUSEstatements. Additionally, a configuration file for Fortitude checks has been added.Key changes:
Refactoring and Consistency Improvements
Math_andMathtoMathOpt_andTypeMathOpt, and standardizing variable names to lowercase (e.g.,Valtoval,MatrixProptomatrixProp). [1] [2] [3] [4] [5]BaseInterpolation_Methodmodule to unify and clarify interface and function names, e.g., consolidatingBaseInterpolation_ToInteger1/BaseInterpolation_ToInteger2intoBaseInterpolation_ToIntegerand introducingInterpolationPoint_ToInteger. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]New Types and Constants
DerivativeTerm_type and the correspondingTypeDerivativeTermparameter to encapsulate derivative term constants. [1] [2]MathOpt_type to include additional mathematical constants and identity matrices.Modularization and Code Organization
USE GlobalDatastatements inBaseType.F90into more granular imports, improving clarity and reducing unnecessary dependencies.Data Structure Enhancements
FEVariable_type by adding new fields such asisInit,tshape, and updated documentation for better clarity on variable usage and structure.Tooling and Configuration
fortitude.tomlconfiguration file to enable and configure code checks, including preview mode, selected checks, file extensions, and line length.