Skip to content

Comments

Ci improvements#66

Open
guillaume-sainthillier wants to merge 3 commits intoeasybill:masterfrom
silarhi:ci-improvements
Open

Ci improvements#66
guillaume-sainthillier wants to merge 3 commits intoeasybill:masterfrom
silarhi:ci-improvements

Conversation

@guillaume-sainthillier
Copy link
Contributor

@guillaume-sainthillier guillaume-sainthillier commented Oct 21, 2024

Advantages to switch on laminas in CI:

  1. Tests are played with lower and higher dependencies packages versions
  2. Tests will be played with future php version (ex: 8.4, ...)
  3. Less code to write

A bug was spotted with jms/serializer starting from 3.16 which was not covered when keeping a composer.lock file

@guillaume-sainthillier guillaume-sainthillier force-pushed the ci-improvements branch 2 times, most recently from 4dbd3a4 to 7c8fff2 Compare October 21, 2024 11:52
@BolZer
Copy link
Member

BolZer commented Oct 25, 2024

@guillaume-sainthillier Thank you for opening the PR; the tooling looks very interesting! I noticed you mentioned encountering an issue with jms/serializer. The commit message here indicates that updating JMS addresses this.

Could you provide more details about the specific issue you encountered?

@guillaume-sainthillier
Copy link
Contributor Author

Hello @BolZer, tests are simply not passing with jms/serializer 3.16. There is a bug they solved starting from 3.18 (schmittjoh/serializer#1417)

@BolZer
Copy link
Member

BolZer commented Dec 9, 2025

@guillaume-sainthillier Hi 👋🏻 , again sorry for the late response. If you like, you can update this PR and resolve the conflict and i will approve the PR. The CI setup needs some improvements.

@guillaume-sainthillier
Copy link
Contributor Author

Hello @BolZer, rebase done, some deprecations failures related to PHP 8.5, so i've disable the fail on deprecation for now, maybe we could fix them into another PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants