Skip to content

Conversation

@ekaterinaasf
Copy link

(created using eb --new-pr)

eb-test added 4 commits December 8, 2021 13:22
….eb, Pint-0.17-GCCcore-10.3.0-Python-3.9.5.eb, plotly.py-4.14.3-GCCcore-10.3.0.eb, boost_histogram-1.2.1-foss-2021a.eb, Zgoubi-6.0.2-GCCcore-10.3.0.eb, georges-2019.2-foss-2021a-Python-3.9.5.eb
@easybuilders easybuilders deleted a comment from boegelbot Jan 8, 2022
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekaterinaasf Thanks a lot for your contribution, and welcome to EasyBuild!

I've made a couple of suggestions for things to change/fix, do let us know if something isn't fully clear!

@boegel boegel added this to the 4.x milestone Jan 8, 2022
@easybuilders easybuilders deleted a comment from boegelbot Jan 8, 2022
@easybuilders easybuilders deleted a comment from boegelbot Jan 8, 2022
@easybuilders easybuilders deleted a comment from boegelbot Jan 8, 2022
@easybuilders easybuilders deleted a comment from boegelbot Jan 9, 2022
@boegel boegel changed the title {math,phys}[foss/2021a] Arrow v6.0.1, LMfit v1.0.3, Pint v0.17, ... w/ Python 3.9.5 {math,phys}[foss/2021a] Arrow v6.0.1, boost_histogram v1.2.1, georges v2019.2, LMfit v1.0.3, plotly.py v,4.14.3, Zgoubi v6.0.2 w/ Python 3.9.5 Jan 9, 2022
@ekaterinaasf ekaterinaasf requested a review from boegel January 9, 2022 12:28
@easybuilders easybuilders deleted a comment from boegelbot Jan 9, 2022
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Jan 9, 2022

@boegelbot please test @ generoso
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=14516 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14516 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7675

Test results coming soon (I hope)...

- notification for comment with ID 1008353390 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member

boegel commented Jan 9, 2022

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
node3100.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/9d97e47fbe2d0f6bc3dbb92813de7038 for a full test report.

@boegel
Copy link
Member

boegel commented Jan 9, 2022

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
node3508.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/b114bb57510150a5b2dc2d1e99e5d75b for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
cnx1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/136cb6a2479f4dee4ee0183a3f645d4a for a full test report.

@boegel
Copy link
Member

boegel commented Jan 9, 2022

Going in, thanks @ekaterinaasf!

@boegel boegel merged commit a40400b into easybuilders:develop Jan 9, 2022
@boegel boegel modified the milestones: 4.x, next release (4.5.2?) Jan 9, 2022
@boegel
Copy link
Member

boegel commented Jan 9, 2022

@ekaterinaasf For future contributions, please open separate pull requests for easyconfig files that are not related to each other; grouping together easyconfigs if one depends on another still makes sense of course, but definitely stick to less than 10 easyconfigs per pull request.

@ekaterinaasf
Copy link
Author

Thank you very much for your help.

Actually, they are all easyconfigs that are needed for one specific one, but I need to wait for its public release. So hope, I'll be back soon with the new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants