-
Notifications
You must be signed in to change notification settings - Fork 763
{math,phys}[foss/2021a] Arrow v6.0.1, boost_histogram v1.2.1, georges v2019.2, LMfit v1.0.3, plotly.py v,4.14.3, Zgoubi v6.0.2 w/ Python 3.9.5 #14516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
….eb, Pint-0.17-GCCcore-10.3.0-Python-3.9.5.eb, plotly.py-4.14.3-GCCcore-10.3.0.eb, boost_histogram-1.2.1-foss-2021a.eb, Zgoubi-6.0.2-GCCcore-10.3.0.eb, georges-2019.2-foss-2021a-Python-3.9.5.eb
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ekaterinaasf Thanks a lot for your contribution, and welcome to EasyBuild!
I've made a couple of suggestions for things to change/fix, do let us know if something isn't fully clear!
easybuild/easyconfigs/b/boost_histogram/boost_histogram-1.2.1-foss-2021a.eb
Outdated
Show resolved
Hide resolved
easybuild/easyconfigs/b/boost_histogram/boost_histogram-1.2.1-foss-2021a.eb
Outdated
Show resolved
Hide resolved
easybuild/easyconfigs/b/boost_histogram/boost_histogram-1.2.1-foss-2021a.eb
Outdated
Show resolved
Hide resolved
easybuild/easyconfigs/b/boost_histogram/boost_histogram-1.2.1-foss-2021a.eb
Outdated
Show resolved
Hide resolved
easybuild/easyconfigs/b/boost_histogram/boost_histogram-1.2.1-foss-2021a.eb
Show resolved
Hide resolved
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@boegelbot please test @ generoso |
|
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1008353390 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegel |
|
Test report by @boegel |
|
Test report by @boegelbot |
|
Going in, thanks @ekaterinaasf! |
|
@ekaterinaasf For future contributions, please open separate pull requests for easyconfig files that are not related to each other; grouping together easyconfigs if one depends on another still makes sense of course, but definitely stick to less than 10 easyconfigs per pull request. |
|
Thank you very much for your help. Actually, they are all easyconfigs that are needed for one specific one, but I need to wait for its public release. So hope, I'll be back soon with the new one. |
(created using
eb --new-pr)