-
Notifications
You must be signed in to change notification settings - Fork 764
Add freetype as dependency to OpenImageIO, as otherwise the build can pick up the system-wide library #9147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add freetype as dependency to OpenImageIO, as otherwise the build can pick up the system-wide library #9147
Conversation
…stem-wide library
|
@paulmelis thanks for your contribution, hopefully the first of many :) although you are only adding a dependency, the tests now require using https for files touched by PRs, please update it (you can do so with |
I'll fix it, but find it a bit surprising:
|
|
@paulmelis yes, the https check was added after that the CI tests are much more extensive than what can be done at |
|
Test report by @migueldiascosta |
|
@paulmelis this was indeed a problem and your PR fixes it, thanks again would you consider also fixing the other |
migueldiascosta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Going in, thanks @paulmelis! |
|
This should definitely also be fixed in |
|
Ah, that was done in #9152, my apologies. :) |
(created using
eb --new-pr)