Fix see::plot.see_parameters_model SORT argument not functioning properly

DESCRIPTION.bak

@@ -0,0 +1,129 @@
+Type: Package
+Package: see
+Title: Model Visualisation Toolbox for 'easystats' and 'ggplot2'
+Version: 0.12.0
+Authors@R:
+    c(person(given = "Daniel",
+             family = "Lüdecke",
+             role = c("aut", "ctb"),
+             email = "d.luedecke@uke.de",
+             comment = c(ORCID = "0000-0002-8895-3206")),
+      person(given = "Dominique",
+             family = "Makowski",
+             role = c("aut", "inv"),
+             email = "dom.makowski@gmail.com",
+             comment = c(ORCID = "0000-0001-5375-9967")),
+      person(given = "Indrajeet",
+             family = "Patil",
+             role = c("aut", "cre"),
+             email = "patilindrajeet.science@gmail.com",
+             comment = c(ORCID = "0000-0003-1995-6531")),
+      person(given = "Mattan S.",
+             family = "Ben-Shachar",
+             role = c("aut", "ctb"),
+             email = "matanshm@post.bgu.ac.il",
+             comment = c(ORCID = "0000-0002-4287-4801")),
+      person(given = "Brenton M.",
+             family = "Wiernik",
+             role = c("aut", "ctb"),
+             email = "brenton@wiernik.org",
+             comment = c(ORCID = "0000-0001-9560-6336")),
+      person(given = "Rémi",
+             family = "Thériault",
+             role = c("aut", "ctb"),
+             email = "remi.theriault@mail.mcgill.ca",
+             comment = c(ORCID = "0000-0003-4315-6788")),
+      person(given = "Philip",
+             family = "Waggoner",
+             role = c("aut", "ctb"),
+             email = "philip.waggoner@gmail.com",
+             comment = c(ORCID = "0000-0002-7825-7573")),
+      person(given = "Jeffrey R.",
+             family = "Stevens",
+             role = "ctb",
+             email = "jeffrey.r.stevens@gmail.com",
+             comment = c(ORCID = "0000-0003-2375-1360")),
+      person(given = "Matthew",
+             family = "Smith",
+             role = "rev",
+             email = "M.Smith3@napier.ac.uk"),
+      person(given = "Jakob",
+             family = "Bossek",
+             role = "rev",
+             email = "bossek@wi.uni-muenster.de"))
+Maintainer: Indrajeet Patil <patilindrajeet.science@gmail.com>
+Description: Provides plotting utilities supporting packages in the 'easystats'
+    ecosystem (<https://github.com/easystats/easystats>) and some extra themes,
+    geoms, and scales for 'ggplot2'. Color scales are based on
+    <https://materialui.co/>.
+    References: Lüdecke et al. (2021) <doi:10.21105/joss.03393>.
+License: MIT + file LICENSE
+URL: https://easystats.github.io/see/
+BugReports: https://github.com/easystats/see/issues
+Depends:
+    graphics,
+    grDevices,
+    R (>= 4.1),
+    stats
+Imports:
+    bayestestR (>= 0.17.0),
+    correlation (>= 0.8.8),
+    datawizard (>= 1.2.0),
+    effectsize (>= 1.0.1),
+    ggplot2 (>= 4.0.0),
+    insight (>= 1.4.1),
+    modelbased (>= 0.13.0),
+    patchwork (>= 1.3.2),
+    parameters (>= 0.28.1),
+    performance (>= 0.15.1)
+Suggests:
+    BH,
+    brms,
+    collapse,
+    curl,
+    DHARMa,
+    discovr,
+    emmeans,
+    factoextra,
+    Formula,
+    ggdag,
+    ggdist,
+    ggraph,
+    ggrepel,
+    ggridges,
+    ggside,
+    glmmTMB,
+    grid,
+    httr2,
+    lavaan,
+    lme4,
+    logspline,
+    marginaleffects,
+    MASS,
+    mclogit,
+    mclust,
+    merDeriv,
+    mgcv,
+    metafor,
+    NbClust,
+    nFactors,
+    psych,
+    qqplotr (>= 0.0.6),
+    randomForest,
+    RcppEigen,
+    rlang,
+    rmarkdown,
+    rstanarm,
+    scales (>= 1.4.0),
+    splines,
+    testthat (>= 3.2.1),
+    tidygraph,
+    vdiffr (>= 1.0.8)
+Encoding: UTF-8
+Language: en-US
+Roxygen: list(markdown = TRUE)
+RoxygenNote: 7.3.3
+Config/testthat/edition: 3
+Config/testthat/parallel: true
+Config/Needs/website: easystats/easystatstemplate
+Config/rcmdcheck/ignore-inconsequential-notes: true

R/plot.parameters_model.R

@@ -410,12 +410,12 @@ plot.see_parameters_model <- function(
   if (isTRUE(sort) || (!is.null(sort) && sort == "ascending")) {
     x$Parameter <- factor(
       x$Parameter,
-      levels = rev(unique(x$Parameter)[order(x$Coefficient)])
+      levels = unique(x$Parameter)[order(x$Coefficient)]
     )
   } else if (!is.null(sort) && sort == "descending") {
     x$Parameter <- factor(
       x$Parameter,
-      levels = unique(x$Parameter)[order(x$Coefficient)]
+      levels = rev(unique(x$Parameter)[order(x$Coefficient)])
     )
   } else {
     # sort coefficients as they appear in the classical summary output by default
@@ -807,10 +807,10 @@ plot.see_parameters_model <- function(
   if (isTRUE(sort) || (!is.null(sort) && sort == "ascending")) {
     x$Level <- factor(
       x$Level,
-      levels = rev(unique(x$Level)[order(x$Coefficient)])
+      levels = unique(x$Level)[order(x$Coefficient)]
     )
   } else if (!is.null(sort) && sort == "descending") {
-    x$Level <- factor(x$Level, levels = unique(x$Level)[order(x$Coefficient)])
+    x$Level <- factor(x$Level, levels = rev(unique(x$Level)[order(x$Coefficient)]))
   } else {
     # sort coefficients as they appear in the classical summary output by default
     x$Level <- factor(x$Level, levels = rev(unique(x$Level)))

generate_missing_snapshots.R

@@ -0,0 +1,61 @@
+# Script to generate missing vdiffr snapshots for sort parameter tests
+# Run this in an R environment with proper dependencies installed
+
+# Install required packages if not already installed
+if (!requireNamespace("testthat", quietly = TRUE)) {
+  install.packages("testthat")
+}
+if (!requireNamespace("vdiffr", quietly = TRUE)) {
+  install.packages("vdiffr")
+}
+if (!requireNamespace("parameters", quietly = TRUE)) {
+  install.packages("parameters")
+}
+if (!requireNamespace("see", quietly = TRUE)) {
+  install.packages("see")
+}
+
+# Load libraries
+library(testthat)
+library(vdiffr)
+library(parameters)
+library(see)
+
+# Ensure we're in the correct directory (package root)
+if (
+  !file.exists("DESCRIPTION") ||
+    !file.exists("tests/testthat/test-plot.parameters_model.R")
+) {
+  stop("Please run this script from the package root directory")
+}
+
+# Set up the test environment
+withr::local_dir(here::here())
+
+# Create test data (matching the test file)
+m <- lm(mpg ~ wt + cyl + gear + disp, data = mtcars)
+result <- parameters::model_parameters(m)
+
+# Generate the missing snapshots
+message("Generating vdiffr snapshots for sort parameter tests...")
+
+# Test context setup
+testthat::test_that("Generate missing sort parameter snapshots", {
+  # Generate ascending sort snapshot
+  vdiffr::expect_doppelganger(
+    title = "plot.model_parameters_sort_ascending",
+    fig = plot(result, sort = "ascending", show_labels = TRUE)
+  )
+
+  # Generate descending sort snapshot
+  vdiffr::expect_doppelganger(
+    title = "plot.model_parameters_sort_descending",
+    fig = plot(result, sort = "descending", show_labels = TRUE)
+  )
+
+})
+
+message("Snapshots should now be generated in tests/testthat/_snaps/plot.parameters_model/")
+message("Expected files:")
+message("- plot-model-parameters-sort-ascending.svg")  
+message("- plot-model-parameters-sort-descending.svg")