Internal heartbeat Timer, use Virtual Thread for Java 21 #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Multi-Version jar, use Virtual Thread instead of Timer for executing the heartbeat test
rPraml
approved these changes
Apr 24, 2025
| @@ -1,11 +1,61 @@ | |||
| package io.ebean.datasource.pool; | |||
|
|
|||
| import io.ebean.datasource.pool.ConnectionPool.Heartbeat; | |||
There was a problem hiding this comment.
Cool: I didn't know this method until now:
Rolands note: Classes will be located in META-INF/versions/21
https://docs.oracle.com/javase/10/docs/specs/jar/jar.html#multi-release-jar-files
Technically it BUILDs needing the Java 21 compiler ... the surefire tests run using the classes from What I need to do is add another test module in order to test the Java 21 code. |
|
Testing java 11 executorFactory with java 21 would be OK for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Multi-Version jar, use Virtual Thread instead of Timer for executing the heartbeat test