Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ncextract enhancement #72

Merged
merged 17 commits into from
Mar 12, 2025
Merged

Conversation

casadoj
Copy link
Collaborator

@casadoj casadoj commented Feb 7, 2025

I have done some changes in the ncextract tool:

  1. Now it produces one file (NetCDF or CSV) for each point of interest. Before, it used to produce one single file with all the points of interest together, which prevented following the development of the process, and caused loss of computing time when the tool stopped before finishing, so there was no output at all.
  2. I've added a filter based on the start and end of the study period. This solves partially issue Add filter by time in ncextract and catchstats #71
  3. I've added a flag (-i or --inflow) to be able to extract the inflow to reservoirs and lakes. When flagged, the tool extracts and adds the time series at all the pixels directly upstream of the provided coordinates. Otherwise, the tool extracts the outflow of the reservoir or lake.

I have updated the test and the documentation in the Wiki.

@doc78
Copy link
Collaborator

doc78 commented Mar 12, 2025

@casadoj Can you please change the base of the pull request to "development"?

@casadoj casadoj changed the base branch from master to development March 12, 2025 10:54
@casadoj
Copy link
Collaborator Author

casadoj commented Mar 12, 2025

@doc78 changed to development. I hope it's fine now.

@doc78 doc78 merged commit b326fbd into development Mar 12, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants