Skip to content

fix: correct loading order for Checklist ContentNode#9464

Open
shruthikha wants to merge 1 commit intoecamp:develfrom
shruthikha:fix-checklist-loading
Open

fix: correct loading order for Checklist ContentNode#9464
shruthikha wants to merge 1 commit intoecamp:develfrom
shruthikha:fix-checklist-loading

Conversation

@shruthikha
Copy link
Copy Markdown

Fix Checklist ContentNode loading behaviour

This PR fixes an issue where checklist items and the "Edit" label were rendered before the skeleton loader.

Problem

ChecklistDisplaySelectedItems was always rendered, even when itemsLoaded was false, causing incorrect UI order.

Solution

Updated conditional rendering logic to:

  • Show skeleton loader while loading
  • Show "Edit" label when no items are selected
  • Show selected items otherwise

Result

Correct rendering order:

  1. Skeleton loader
  2. Edit label OR selected items

Closes #9462

Ensure skeleton loader is shown before content and prevent checklist items from rendering during loading.
@shruthikha
Copy link
Copy Markdown
Author

Heyyy! I've submitted a fix for this issue.

The problem was that checklist items were rendering even when itemsLoaded was false, causing incorrect UI order. I've updated the conditional rendering to ensure the skeleton loader appears first, followed by either the "Edit" label or selected items.

Let me know if any changes are needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Checklist ContentNode loading behaviour

1 participant