fix: correct loading order for Checklist ContentNode#9464
Open
shruthikha wants to merge 1 commit intoecamp:develfrom
Open
fix: correct loading order for Checklist ContentNode#9464shruthikha wants to merge 1 commit intoecamp:develfrom
shruthikha wants to merge 1 commit intoecamp:develfrom
Conversation
Ensure skeleton loader is shown before content and prevent checklist items from rendering during loading.
Author
|
Heyyy! I've submitted a fix for this issue. The problem was that checklist items were rendering even when itemsLoaded was false, causing incorrect UI order. I've updated the conditional rendering to ensure the skeleton loader appears first, followed by either the "Edit" label or selected items. Let me know if any changes are needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Checklist ContentNode loading behaviour
This PR fixes an issue where checklist items and the "Edit" label were rendered before the skeleton loader.
Problem
ChecklistDisplaySelectedItemswas always rendered, even whenitemsLoadedwas false, causing incorrect UI order.Solution
Updated conditional rendering logic to:
Result
Correct rendering order:
Closes #9462