Skip to content

Enable sensible CodeQL scanning#9519

Draft
Copilot wants to merge 2 commits intodevelfrom
copilot/enable-sensible-codeql
Draft

Enable sensible CodeQL scanning#9519
Copilot wants to merge 2 commits intodevelfrom
copilot/enable-sensible-codeql

Conversation

Copy link
Copy Markdown

Copilot AI commented Apr 18, 2026

Summary

Enable CodeQL for this repository with a dedicated workflow and a scoped configuration that keeps scans useful and efficient.

Changes

  • Add .github/workflows/codeql.yml to run CodeQL on:
    • pull requests
    • pushes to devel
    • merge queue (merge_group)
    • weekly schedule
    • manual dispatch
  • Configure CodeQL matrix for:
    • javascript-typescript
  • Use build-mode: none
  • Add .github/codeql/codeql-config.yml with:
    • security-and-quality query suite
    • pragmatic path exclusions for legacy, generated, and test-heavy folders (frontend-old, e2e, translation, .ops, coverage/dist/node_modules, and selected test/fixture directories)
  • Follow-up fix from PR feedback:
    • remove unsupported php language from the CodeQL matrix so workflow initialization succeeds on GitHub Actions

Validation

  • YAML syntax validated locally for both new files
  • Parallel validation completed:
    • Code Review: no comments
    • CodeQL Security Scan: no alerts

Agent-Logs-Url: https://github.com/ecamp/ecamp3/sessions/7c1e7c9a-2d76-40e2-b54a-d2dcd752b597

Co-authored-by: manuelmeister <3001985+manuelmeister@users.noreply.github.com>
@BacLuc
Copy link
Copy Markdown
Contributor

BacLuc commented Apr 18, 2026

Computer says no:
Did not recognize the following languages: php

https://github.com/ecamp/ecamp3/actions/runs/24598249050/job/71940243542?pr=9519

@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Copy link
Copy Markdown
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot the run hat errors

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 87d97d9 by removing unsupported php from the CodeQL matrix. That run failure is resolved. No UI changes were made, so there is no UI screenshot.

Agent-Logs-Url: https://github.com/ecamp/ecamp3/sessions/1c261fba-e39a-4940-99f3-d0cd3df5719c

Co-authored-by: manuelmeister <3001985+manuelmeister@users.noreply.github.com>
Copy link
Copy Markdown
Author

Copilot AI commented Apr 18, 2026

Computer says no:
Did not recognize the following languages: php

...

Fixed in 87d97d9. I removed php from the CodeQL language matrix because this runner’s CodeQL bundle does not recognize it, so the workflow now initializes successfully with javascript-typescript.

Copy link
Copy Markdown
Author

Copilot AI commented Apr 18, 2026

@copilot the run hat errors

Addressed in 87d97d9. The failing php CodeQL language entry was removed; that specific init error is fixed. No UI changes were made, so there is no UI screenshot.

@BacLuc
Copy link
Copy Markdown
Contributor

BacLuc commented Apr 18, 2026

It didn't find anything. so i would say we let it be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants