Skip to content

Use precalculated hasChecklists flag for checklist navigation item#9698

Open
manuelmeister wants to merge 8 commits into
ecamp:develfrom
manuelmeister:performance/prevent-checklist-request
Open

Use precalculated hasChecklists flag for checklist navigation item#9698
manuelmeister wants to merge 8 commits into
ecamp:develfrom
manuelmeister:performance/prevent-checklist-request

Conversation

@manuelmeister

Copy link
Copy Markdown
Member

With this we can save us an initial call to checklists.

@manuelmeister manuelmeister marked this pull request as draft May 6, 2026 16:02

@carlobeltrame carlobeltrame left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only courses may use checklists, and not only checklists determine whether a camp is a course or not. Can we name this a little more neutrally, e.g. hasChecklists?

@manuelmeister manuelmeister added the deploy! Creates a feature branch deployment for this PR label May 6, 2026
@manuelmeister manuelmeister changed the title Use dynamically calculated isCourse flag for checklist navigation item Use calculated hasChecklists flag for checklist navigation item May 6, 2026
@manuelmeister manuelmeister changed the title Use calculated hasChecklists flag for checklist navigation item Use precalculated hasChecklists flag for checklist navigation item May 6, 2026
@manuelmeister manuelmeister temporarily deployed to feature-branch May 6, 2026 20:57 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown

Feature branch deployment ready!

Name Link
😎 Deployment https://pr9698.ecamp3.ch/
🔑 Login test@example.com / test
🕒 Last deployed at Wed Jun 10 2026 22:42:42 GMT+0200
🔨 Latest commit 5bf92267909b25922e8b616bf08790fa341ff29c
🔍 Latest deploy log https://github.com/ecamp/ecamp3/actions/runs/27304626712/job/80659966973
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Comment thread api/src/Entity/Camp.php Outdated
Comment thread api/src/State/ChecklistRemoveProcessor.php Outdated
Comment thread api/src/State/ChecklistRemoveProcessor.php Outdated
Comment thread api/migrations/dev-data/data.sql Outdated
@manuelmeister manuelmeister marked this pull request as ready for review May 12, 2026 12:03
@manuelmeister manuelmeister temporarily deployed to feature-branch May 12, 2026 12:06 — with GitHub Actions Inactive
@manuelmeister manuelmeister requested a review from a team May 12, 2026 12:23
@manuelmeister manuelmeister temporarily deployed to feature-branch May 12, 2026 17:43 — with GitHub Actions Inactive
@manuelmeister

Copy link
Copy Markdown
Member Author

Core Meeting Decision

We don't want a DB field. This could be solved with replacing the collection link with a array of iris (removing the ApiFilter on Checklist.php for camp)

@manuelmeister manuelmeister temporarily deployed to feature-branch June 10, 2026 20:39 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy! Creates a feature branch deployment for this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants