feat: add dedicated MaterialItem\AssertBelongsToSameCamp validator using previous_data#9960
Open
BacLuc wants to merge 2 commits into
Open
feat: add dedicated MaterialItem\AssertBelongsToSameCamp validator using previous_data#9960BacLuc wants to merge 2 commits into
BacLuc wants to merge 2 commits into
Conversation
✅ Feature branch deployment ready!
|
…ing previous_data Removes the `compareToPrevious` flag from the generic `AssertBelongsToSameCamp` constraint (it was never used). Implements the protection against MaterialItem camp transfer as a dedicated validator in the MaterialItem namespace, which uses `previous_data` to compare the new materialList against the original camp. Fixes ecamp#9461 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
34a0ea0 to
b9f4bf4
Compare
Contributor
Author
|
Not really necessary because the materialItem has a separate camp property which can't be changed. |
b9f4bf4 to
2409a0e
Compare
Contributor
Author
Not needed anymore since we have an immutable camp pointer with commit d83722e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
compareToPreviousflag from the genericAssertBelongsToSameCampconstraint (it was never used). Implements the protection against MaterialItem camp transfer as a dedicated validator in the MaterialItem namespace, which usesprevious_datato compare the new materialList against the original camp.Fixes #9461
And remove support for options in App\Validator\AssertBelongsToSameCamp