Add accessor for included pty instance #1109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
force-pushed
the
add_accessor_for_pty
branch
from
7482fa4 to
8fa4a3e
Compare
|
The cleancheck fails with but I can't see how this relates to my commit... |
Test Results 602 files - 34 602 suites - 34 13m 18s ⏱️ - 23m 12s Results for commit 15be3b0. ± Comparison against base commit 04105c2. This pull request removes 1217 tests.♻️ This comment has been updated with latest results. |
|
@jonahgraham @akurtakov any chance to push this forward? |
laeubi
force-pushed
the
add_accessor_for_pty
branch
2 times, most recently
from
41e3ea7 to
53360da
Compare
|
It seems the cleanup is modify the |
laeubi
force-pushed
the
add_accessor_for_pty
branch
2 times, most recently
from
1c747f8 to
36f56c8
Compare
|
Looks like it was actually the Year that needs to be changed here... |
Currently if I get passed a Process from by a method call I can check it for the Spawner and can already call special methods like hangup(). But there is no way to get access the the PTY used to create the Spawner so for example one can't call PTY#setTerminalSize or query any other properties. This now adds a new method pty() that returns this instance for further investigation and actions.
laeubi
force-pushed
the
add_accessor_for_pty
branch
from
36f56c8 to
15be3b0
Compare
|
Build is finally green! |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if I get passed a Process from by a method call I can check it for the Spawner and can already call special methods like hangup(). But there is no way to get access the the PTY used to create the Spawner so for example one can't call PTY#setTerminalSize or query any other properties.
This now adds a new method pty() that returns this instance for further investigation and actions.
See