Move to migrated platform terminal

[laeubi]

FYI @jonahgraham

[laeubi]

@ruspl-afed as discussed in the IDE call yesterday, this is the PR for adjustments in CDT to migrate to the new terminal view, would be great if you can help with this as well.

[ruspl-afed]

Software being installed: org.eclipse.cdt.debug.application.product 12.2.0.qualifier

Please have a look here

[laeubi]

The feature is still there! So this should not be the problem, it currently fails for some org.bouncycastle stuff, maybe I should try first a PR that uses ibuilds repo to not change too much things at once....

[jld01]

The feature is still there! So this should not be the problem, it currently fails for some org.bouncycastle stuff, maybe I should try first a PR that uses ibuilds repo to not change too much things at once....

The bouncycastle version issue seems unrelated to this PR. I have been experimenting on #1241. It would be preferable to use a separate PR for releng changes, but I won't have time to look at this again today. Please feel free to work on a solution yourselves.

[ruspl-afed]

@laeubi I plan to continue looking at your changes today, please let me know about your plans.
I also agree that we should split PRs

[laeubi]

I think

• [releng] Start building against Eclipse Platform 4.37 I-builds #1241

needs investigation first and if that works I'll rebase my PR to see what else fails (maybe).

[ruspl-afed]

needs investigation first

looking into it. may be just an infra failure

[ruspl-afed]

may be just an infra failure

at least license check converged after restart (was ClearlyDefined failure)
restarted main build action as well to see what is wrong

[ruspl-afed]

restarted main build action as well to see what is wrong

I think org.eclipse.cdt.ui.tests.buildconsole.BuildConsoleTests is not happy @laeubi

[ruspl-afed]

2025-07-18T08:23:21.2437933Z Running org.eclipse.cdt.ui.tests.buildconsole.BuildConsoleTests
2025-07-18T10:02:34.8750427Z ##[error]The operation was canceled.

[laeubi]

See here: #1241 the test seem to timeout currently :-\

[jld01]

@laeubi it looks like https://github.com/eclipse-cdt/cdt/blob/main/core/org.eclipse.cdt.ui.tests/src/org/eclipse/cdt/ui/testplugin/EditorTestHelper.java#L376 was broken by the recent platform UI change: eclipse-platform/eclipse.platform.ui@0e4942b

[laeubi]

Renaming a private (!) field of an internal class can merely be seen as breaking change .. I'm not sure why CDT do the same bad hacks as Platform did, but it has to do the same adaption than here then:

eclipse-platform/eclipse.platform.ui@0e4942b#diff-54c81a16536eba9489797a9d665c195f0908163e2c7b14ad055d78cc62579fdaL193

[ruspl-afed]

@laeubi now CDT uses the later Platform I build to simplify Terminal-related changes
Please let me know regarding your further plans

[laeubi]

Rebase done, lets see if it works out better :-)

I think I should probably squash all commits into one if everything works.

[ruspl-afed]

Please have a look at product manifest of org.eclipse.cdt.debug.application.product @laeubi

[laeubi]

Please have a look at product manifest of org.eclipse.cdt.debug.application.product @laeubi

It was actually the feature using a wrong version here...

[laeubi]

Some more feature cleanups ...

[ruspl-afed]

It was actually the feature using a wrong version here...

Sorry for the wrong pointer, I hope that at least direction was right :)

[laeubi]

Yes no problem, now the build actually starts and resolves it gives better errors to work on... code cleaniness check seem needs adjustments at least I see some exceptional handling from @jonahgraham last time something was moved to platform... so we are getting closer!

[ruspl-afed]

for code cleanliness failure the message is

Missing about.ini entry in org.eclipse.tm.terminal.connector.ssh.feature/build.properties

[ruspl-afed]

I'm thinking how we can converge on this. May be we can split this PR and first transfer CDT-DSF to a new Platform Terminal?

[laeubi]

Some thing might be able to be extracted, but I think there is not much benefit and will possibly result in conflicts in the build. I think I'm almost done with that and then I can try to came up with trying it in smaller chunks, e.g. currently the actual deletion of stuff is the far biggest change here, so one might simply let linger around the deleted stuff and then have one PR that actually delete it (but nothing else changes).

I also bumped the major version for the both CDT connectors from 4 > 5, since they are using new API in their own API it seems not useful to not do it.

One might think about after doing the migration to also clean up these remaining connects and maybe even change their namespace as well to prevent confusion with the old ones. The also their version can be reset and maybe not export everything as API...

e.g. org.eclipse.tm.terminal.connector.cdtserial -> org.eclipse.cdt.terminal.connector.serial (and move it into the core or launch or debug or ... subfolder)
and org.eclipse.tm.terminal.connector.remote voud probabbly better go to the remote and be renamed org.eclipse.remote.terminal.connector.

But I would leave this aspects to the CDT maintainer to decide!

[ruspl-afed]

My congrats with the first fully green build @laeubi !

There are two kind of things that I cannot merge without visa from CDT PL @jonahgraham

1. major version bumps, because it raises a lot of further questions
2. removal of anything, because CDT codebase is very conservative

What I think I can merge is switch of CDT itself to the new Platform Terminal
I'm not sure how useful this partial change could be, but at least it may reduce the volume of further discussions.

[laeubi]

major version bumps, because it raises a lot of further questions

I think that is the cleanest solution here, as it depends on new API that is leaked into the bundles own API. An alternative would be the rename / reversion of the whole thing. In the end I think no one should actually API wise depend on a connector anyways, but it is API at the moment sadly.

removal of anything, because CDT codebase is very conservative

If one depends on anything from the old world, it is still there in the old releases an/or branches, it does not seem useful to retain the sources here if they have evolved/moved to another project I think. Also I think usual users/extenders of CDT should never notice that particular thing:

• Everything from CDT is only referenced internally and do not surface to API
• The Connectors are actually extensions to the terminal view and nothing tied to CDT itself

[laeubi]

I now squashed everything, so this is ready for review, will try to extract some aspects into separate PRs now.

[laeubi]

GDB Migration:

• Migrate GDB to new Eclipse Terminal View Support #1246

[laeubi]

remote migration:

• Migrate eclipse.remote to new Platform Terminal API #1247

[laeubi]

Migration of remaining connectors to new API including major version bump:

• Migrate CDT provided connectors to the new API #1248

[laeubi]

Using of the new bundle names from platform in feature files:

• Use migrated bundles in existing features and cleanup #1249

[ruspl-afed]

Thank you for supporting this PR in actual state @laeubi !
I suggest to remove added .project manifests from it to make it even more clear

[jonahgraham]

@ruspl-afed are you able to merge this? You have done the work to review so far.

thanks @laeubi for this PR.

[laeubi]

@jonahgraham I think I should rebase the PR and have already creates smaller chunks that should be merged first:

• Migrate CDT provided connectors to the new API #1248
• Use migrated bundles in existing features and cleanup #1249

so I will convert this to draft, @ruspl-afed has had some concerns but these are maybe better discussed on the smaller PRs.