Terminal control delegate #1275
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the old Terminal View is referenced in some other codebase and we can not update them all at once. To ease the transition this now do the following: - deprecate the bundles to make consumer aware of the new terminal view - implement a delegation where the old code calls redirect / transform to the new ones
|
It was discussed in the IDE Dev Call that it was discussed that it is likely to much effort here:
I will keep this open in case some more points are to be added here or we came up with a really compelling reason to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the "old" terminal.control bundle and implement some of its functions as a delegate to the migrated platform code.
Not yet finished... maybe would be better to first restore the bundle in one PR and then implement the delegation in another.