[#2955] MQTT 5 support #3654
Merged
[#2955] MQTT 5 support #3654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harism
force-pushed
the
mqtt_5
branch
3 times, most recently
from
1b207e5
to
ba692fb
Compare
sophokles73
requested review from
sophokles73
and removed request for
kaniyan
sophokles73
added
MQTT Adapter
Feature Request
sophokles73
requested changes
Sep 24, 2024
There was a problem hiding this comment.
@harism Sorry for the delay, I had been on a four week vacation and didn't find the time to review.
This looks very good 👍
Would you mind undoing the changes to the copyright header comment? Then we are good to merge ...
...-base/src/main/java/org/eclipse/hono/adapter/mqtt/AbstractVertxBasedMqttProtocolAdapter.java
Outdated
Show resolved
Hide resolved
sophokles73
reviewed
Sep 27, 2024
...-base/src/main/java/org/eclipse/hono/adapter/mqtt/AbstractVertxBasedMqttProtocolAdapter.java
Outdated
Show resolved
Hide resolved
sophokles73
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial simplified MQTT 5 support with using Vert.x MQTT 5 support methods.