Langium generator: Transform to npm workspace and remove web #1810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
- Align template structure with target structure - Integrate a global tsconfig.build.json - Unify how build and compile is done - Enhance tests - Updated relevant dependencies and aligned version in the repo - Move test output to packages/generator-langium/test/genetator-tests - Implement review comments: tmLanguage location and package names use languageId - Do not use "run --prefix" and align eslint+plugin version with typescript - Updated READMEs - align vitest usage
kaisalmen
force-pushed
the
generator-rework
branch
from
09e17af to
a6d4692
Compare
kaisalmen
changed the title
|
I rebased the PR and this is ready for review. |
There was a problem hiding this comment.
Copilot reviewed 57 out of 69 changed files in this pull request and generated no comments.
Files not reviewed (12)
- .editorconfig: Language not supported
- package.json: Language not supported
- packages/generator-langium/package.json: Language not supported
- packages/generator-langium/templates/.vscode/extensions.json: Language not supported
- packages/generator-langium/templates/.vscode/launch.json: Language not supported
- packages/generator-langium/templates/cli/.package.json: Language not supported
- packages/generator-langium/templates/core/.vscode/extensions.json: Language not supported
- packages/generator-langium/templates/core/langium-config.json: Language not supported
- packages/generator-langium/templates/core/tsconfig.json: Language not supported
- packages/generator-langium/templates/gitignore.txt: Language not supported
- packages/generator-langium/templates/package.json: Language not supported
- packages/generator-langium/templates/packages/cli/package.json: Language not supported
Comments suppressed due to low confidence (2)
packages/generator-langium/src/index.ts:359
- The removal of the '.replace(TSCONFIG_BASE_NAME, tsconfigBaseName)' substitution may break template substitutions for tsconfig placeholders. Confirm that none of the relevant templates depend on this variable.
_replaceTemplateWords(fileExtensionGlob: string, languageName: string, languageId: string, content: string | Buffer): string {
packages/generator-langium/src/index.ts:325
- The condition to skip the build based on the 'skip-build' argument is a significant change. Verify that this behavior is intentional and that all build scenarios are handled appropriately in the workspace setup.
if(!this.args.includes('skip-build')) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will replace #1520 but is not yet ready for review