-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DR: multi-repo setup #263
base: main
Are you sure you want to change the base?
DR: multi-repo setup #263
Conversation
Co-authored-by: Maximilian Sören Pollak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great write-up.
I don't have a strong opinion about the different solutions.
Regarding the proposed solution "Copying", I just asked myself, how this works in the different scenarios for local builds:
SCORE main
gets updated, most module-repos are not checked out- Single module-repo gets updated,
SCORE main
may be locally outdated SCORE main
and 1 module-repo gets updated (new feature docs + implementation)- Finally these changes get committed by 2 PRs. The
SCORE main
PR needs to be merged first so that the module-PR can use a valid feature as a link target. Doable, and maybe not a common use case.
- Finally these changes get committed by 2 PRs. The
For fast, local feedback it should be possible to build the docs with SCORE main
and one selected module-repo only.
Do you think this is possible? I'm a bazel newbie, so I'm unsure :)
review findings
Signed-off-by: Alexander Lanin <[email protected]>
Applying the meeting minutes was surprisingly trivial, as in the end we have simply picked solution 2 for all use cases.
|
The created documentation from the pull request is available at: docu-html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one comment regarding sentence understandability.
The created documentation from the pull request is available at: docu-html |
The created documentation from the pull request is available at: docu-html |
update summary Signed-off-by: Alexander Lanin <[email protected]>
The created documentation from the pull request is available at: docu-html |
The created documentation from the pull request is available at: docu-html |
Please have a look whether option 2 still is our favorite! @PhilipPartsch @MaximilianSoerenPollak @ltekieli @nradakovic @hoe-jo @danwos |
Dear bazel and docs-as-code people: please review the entire DR.
All other stakeholders (e.g. process experts) should focus on reviewing the use cases / requirements and constraints.
Readable version: https://github.com/AlexanderLanin/score/blob/docs-multirepo/docs/_tooling/decision-records/multirepo.md
Closes #218