Added inbuilt PDF viewer - #103
Open
hgvanpariya wants to merge 1 commit into
Open
hgvanpariya wants to merge 1 commit into
hgvanpariya wants to merge 1 commit into
Conversation
|
Can one of the admins verify this patch? |
Contributor
|
Thanks for the patch! What is the license on this component? |
Contributor
Author
|
@turesheim : I added this : https://marketplace.eclipse.org/content/gnostice-free-pdfnoffice-viewer-eclipse-plugin |
Contributor
Author
|
do you think we can use this ? |
Contributor
I'm afraid the answer is no. At least not without getting approval from the Board of Directors. This is not in the list of pre-approved licenses https://www.eclipse.org/legal/licenses.php and is not even a OSI-approved license. |
Contributor
|
Hello @hgvanpariya If this PR is still actual, you can try to run https://github.com/eclipse/dash-licenses on it locally to inspect licensing issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added PDFViewer : gnostice
It will add PDF viewer inside eclipse. #84