Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(chat): minor chat style improvements #15112

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

planger
Copy link
Contributor

@planger planger commented Mar 4, 2025

What it does

Removes the focus outline appearing at the bottom of Monaco editors of code parts in the chat response and fine-tunes the margins of the actions in the chat input.

How to test

Open the chat and ask e.g. @Universal to print some typescript code and ensure that there is no focus-colored outline at the bottom of the code blocks.

Also have a look at the chat input to check if the margins of the actions below the chat input look fine and even.

Before:
image

After:
image

Follow-ups

None

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

None

Review checklist

Reminder for reviewers

Removes the focus outline appearing at the bottom of Monaco editors of code parts in the chat response and fine-tunes the margins of the actions in the chat input.
@planger planger requested a review from eneufeld March 4, 2025 14:27
@planger planger mentioned this pull request Mar 4, 2025
63 tasks
@JonasHelming
Copy link
Contributor

@eneufeld Ping

@planger
Copy link
Contributor Author

planger commented Mar 18, 2025

@eneufeld Ping :-)

@planger planger merged commit 632ed67 into master Mar 19, 2025
10 of 11 checks passed
@github-actions github-actions bot added this to the 1.60.0 milestone Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants