Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve plugin package localization #15142

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

msujew
Copy link
Member

@msujew msujew commented Mar 6, 2025

What it does

Closes #15093

Prevents the issue from appearing by no longer using a regex at all.

How to test

See reproduction steps of #15093.

Review checklist

Reminder for reviewers

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with the MarsCode AI extension and the fix worked for me.

Good work! I also like the simplification, always good to get rid of regexes where not needed. 🎉

@msujew msujew merged commit f82aba4 into master Mar 19, 2025
10 of 11 checks passed
@msujew msujew deleted the msujew/fix-plugin-package-localization branch March 19, 2025 13:42
@github-actions github-actions bot added this to the 1.60.0 milestone Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Incorrect translation of marscode ai plugin: Regular expression does not support keys containing spaces
2 participants