Put all prompts under MIT license #15159
Open
+464
−379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@msujew No technical review is needed from you, but could you check and +1 the general operation as a second project lead before I ask all contributor to +1 on the PR, please? |
msujew
reviewed
Mar 11, 2025
| @@ -1,19 +1,12 @@ | |||
| /* eslint-disable @typescript-eslint/tslint/config */ | |||
There was a problem hiding this comment.
Question: Will there be enough files in the framework with an MIT license to warrant a change to our eslint check? We could make the MIT license a valid license for the check.
There was a problem hiding this comment.
Thought about it, but at the moment, I believe we are stable.
eneufeld
reviewed
Mar 12, 2025
| @@ -0,0 +1,45 @@ | |||
| /* eslint-disable @typescript-eslint/tslint/config */ | |||
| // ***************************************************************************** | |||
| // Copyright (C) {year, original author} and others. | |||
There was a problem hiding this comment.
shouldn't this be filled?
There was a problem hiding this comment.
Good catch, fixed for all headers
|
@eneufeld Ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #15158
What it does
In our repository (Theia), we have several prompt templates.
These templates are strings and are user editable, so the user has a UI to change them at runtime in the tool. As we do not want to get into any license discussions and allow users to adapt their prompts, this PR extracts all prompt templates to separate files and changes their license to MIT for these prompt templates.
The PR also adds a plain MIT license file to the repo, as the existing one is targeted at VS Code code.
See here for more details, we will let contributors agree on this PR on the re licensing
How to test
All agents should work without any change.
Follow-ups
Breaking changes
Attribution
Review checklist
Reminder for reviewers