propagate CompositionOptions to fetchAffordances and _getPartialTDs

[dvalnn]

Change ThingModelHelpers.fetchAffordances() to take CompositionOptions as input and propagate them to successive _getPartialTDs calls.

This allows for correct replacement of placeholders via the CompositionOptions map in Thing Models fetched via fetchAffordances.

Example use case:

Base thing model with placeholders

{
    "@context": [
        "https://www.w3.org/2022/wot/td/v1.1"
    ],
    "@type": "tm:ThingModel",
    "title": "base_thing",
    "version": {
        "model": "0.0.1"
    },
    "id": "urn:uuid:{{THING_UUID_V4}}",
    "description": "The most basic thing",
    "securityDefinitions": {
        "nosec_sc": {
            "scheme": "nosec"
        }
    }
}

Another thing model that extends the base thing model

{
    "@context": [
        "https://www.w3.org/2022/wot/td/v1.1"
    ],
    "@type": "tm:ThingModel",
    "title": "extended_thing",
    "version": {
        "model": "0.0.1"
    },
    "description": "Extends the base thing with some properties",
    "links": [{
        "rel": "tm:extends",
        "href": "file://./test/thing-model/tmodels/placeholderExtension/BaseThingWithPlaceholder.tm.jsonld",
        "type": "application/tm+json"
    }],
    "properties": {
        "some_property": {
            "type": "string",
            "description": "Some property",
            "forms": [{
                "href": "mqtt://{{MQTT_BROKER_ADDR}}",
                "mqv:topic": "{{THING_MODEL}}/{{THING_UUID_V4}}/properties/some_property",
                "op": "observeproperty",
                "mqv:qos": 1,
                "mqv:retain": false,
                "contentType": "application/json"
            }]
        }
    }
}

map:

const map = {
    THING_MODEL: "extended_thing",
     THING_UUID_V4: "bf2c24bc-9232-454d-ac17-90feb3647b71",
     MQTT_BROKER_ADDR: "example.org:1883"
 }

In this scenario, given a valid map, the current implementation will fail to correctly instantiate the partial Thing Description for the "extended_thing" model, as the composition options are not propagated by fetchAffordances() to the following _getPartialTDs() calls.

[relu91]

Thank you @dvalnn, changes look good. Just two things left:

• Sign the ECA (see https://github.com/eclipse-thingweb/node-wot/blob/master/CONTRIBUTING.md#legal-requirements)
• Can you please rebase and use a commit message style according to https://github.com/eclipse-thingweb/node-wot/blob/master/CONTRIBUTING.md#commits

@danielpeintner @egekorkan we should a Contributing.md file here too.

[dvalnn]

I have no problem signing the ECA, its just that Eclipse for some reason does not support "." in emails?
Seems like the sign-up page is broken at the moment...

[dvalnn]

In the meantime, I squashed and reworded the commits so if everything looks good, I'll just wait for feedback regarding the ECA issue.

[relu91]

Thank you! to be honest, this is the first time we see that. I have an email containing a "." too. Maybe, it is just some recent regression. We'll try to contact the webmaster. I'll let you know asap.

[relu91]

@dvalnn I still have not received a response from the eclipse webmaster, but I tried to create a new account with [email protected], and it worked. Can you try again? maybe it was just some temporary issue...

[dvalnn]

I finally managed to sign the ECA (and create an account) by just suppressing the ".", from my email (which works the same as having the "." in it seems)
Just submitting my email address as normal was still throwing the same error for me.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.33%. Comparing base (a6943fa) to head (3490c5f).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   65.23%   69.33%   +4.10%     
==========================================
  Files           1        1              
  Lines         558      300     -258     
  Branches      224       79     -145     
==========================================
- Hits          364      208     -156     
+ Misses        155       70      -85     
+ Partials       39       22      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[relu91]

Ok we are almost there, can you run priettier? Thanks!

[egekorkan]

Looks good! Should we bump the version already?

[relu91]

we can do it later