Skip to content

Bugfix parsing control transfer requests #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SeanHowsonAdvCo wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Bugfix parsing control transfer requests #218

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
637fa4a
No longer using request_value to get request type.
SeanHowsonAdvCo Nov 26, 2025
3f22f98
Removal of shift.
SeanHowsonAdvCo Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion common/core/src/ux_device_stack_control_request_process.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,10 @@
/* improved interface request */
/* process with print class, */
/* resulting in version 6.3.0 */
/* 26-11-2025 Sean Howson Modified comment(s), */
/* Fixed initial request */
/* filter to evaluate correct */
/* byte of transfer request. */
/* */
/**************************************************************************/
UINT _ux_device_stack_control_request_process(UX_SLAVE_TRANSFER *transfer_request)
Expand Down Expand Up @@ -136,7 +140,7 @@ ULONG application_data_length;

/* Filter for GET_DESCRIPTOR/SET_DESCRIPTOR commands. If the descriptor to be returned is not a standard descriptor,
treat the command as a CLASS command. */
if ((request == UX_GET_DESCRIPTOR || request == UX_SET_DESCRIPTOR) && (((request_value >> 8) & UX_REQUEST_TYPE) != UX_REQUEST_TYPE_STANDARD))
if ((request == UX_GET_DESCRIPTOR || request == UX_SET_DESCRIPTOR) && (((request_type >> 8) & UX_REQUEST_TYPE) != UX_REQUEST_TYPE_STANDARD))
{

/* This request is to be handled by the class layer. */
Expand Down