Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialize local variables before use #693

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

initialize local variables before use #693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cce8be3
initialize local variables before use
kraj Dec 24, 2019
41362e6
cmake: Disable -Wno-misleading-indentation with clang-10 onwards
kraj Dec 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,11 @@ if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION VERSION_
list (APPEND C_CXX_WARNING_FLAGS -Wno-misleading-indentation)
endif ()

# clang-10 added -Wmisleading-indentation as well, skip it too
if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER "9")
list (APPEND C_CXX_WARNING_FLAGS -Wno-misleading-indentation)
endif ()

# Warnings as errors?
if (WERROR)
list (APPEND C_CXX_WARNING_FLAGS -Werror)
Expand Down
8 changes: 4 additions & 4 deletions src/kxtj3/kxtj3.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,7 @@ upm_result_t kxtj3_sensor_software_reset(const kxtj3_context dev)
if (kxtj3_set_bit_on(dev, KXTJ3_CTRL_REG2, KXTJ3_CTRL_REG2_SRST) != UPM_SUCCESS)
return UPM_ERROR_OPERATION_FAILED;

uint8_t ctrl_reg2_data;
uint8_t ctrl_reg2_data = 0;
kxtj3_read_register(dev, KXTJ3_CTRL_REG2, &ctrl_reg2_data);

uint8_t srst_counter = 0;
Expand Down Expand Up @@ -824,7 +824,7 @@ upm_result_t kxtj3_enable_interrupt_pin(const kxtj3_context dev, KXTJ3_INTERRUPT
KXTJ3_INTERRUPT_RESPONSE_T response_type)
{
assert(dev != NULL);
uint8_t int_reg_value;
uint8_t int_reg_value = 0;
kxtj3_read_register(dev, KXTJ3_INT_CTRL_REG1, &int_reg_value);

if (polarity)
Expand Down Expand Up @@ -865,7 +865,7 @@ upm_result_t kxtj3_set_interrupt_response(const kxtj3_context dev, KXTJ3_INTERRU
bool kxtj3_get_interrupt_status(const kxtj3_context dev)
{
assert(dev != NULL);
uint8_t status_reg_value;
uint8_t status_reg_value = 0;
kxtj3_read_register(dev, KXTJ3_STATUS_REG, &status_reg_value);
if (!(status_reg_value & KXTJ3_STATUS_REG_INT))
return false;
Expand Down Expand Up @@ -955,7 +955,7 @@ kxtj3_wakeup_axes kxtj3_get_wakeup_axis_and_direction(kxtj3_context dev)
{
assert(dev != NULL);

uint8_t int_source2_value;
uint8_t int_source2_value = 0;
kxtj3_read_register(dev, KXTJ3_INT_SOURCE2, &int_source2_value);

kxtj3_wakeup_axes wakeup_axis;
Expand Down