Fix premature tracer span closure for fire-and-forget and publish#6083
Open
tsegismont wants to merge 2 commits intoeclipse-vertx:masterfrom
Open
Fix premature tracer span closure for fire-and-forget and publish#6083tsegismont wants to merge 2 commits intoeclipse-vertx:masterfrom
tsegismont wants to merge 2 commits intoeclipse-vertx:masterfrom
Conversation
2 tasks
Member
|
I'd rather name processed by ack which is a common terminology, we also used this for acking MQTT messages |
Member
Author
|
Done |
vietj
reviewed
Apr 24, 2026
Add MessageConsumerOptions#setAutoAck and Message#ack() so consumers can defer trace span closure until async/blocking handler completion. Some portions of this content were created with the assistance of IBM Bob. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #6021
Add
MessageConsumerOptions#setAutoProcessedandMessage#processed()so consumers can defer trace span closure until async/blocking handler completion.Some portions of this content were created with the assistance of IBM Bob.