Feature/csv output 1.6.1 #78
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdeconinck
reviewed
Dec 4, 2025
Collaborator
wdeconinck
left a comment
wdeconinck
left a comment
There was a problem hiding this comment.
Looks good to me! That will be nice.
Just a small change request in real / integer divisions, just to be certain.
wdeconinck
reviewed
Dec 4, 2025
src/fiat/gstats/gstats_print.F90
Outdated
| ! TIMING INFORMATION | ||
| ICALLS = NCALLS(JNUM)/2 | ||
| IF (ICALLS > 1) THEN | ||
| ZSTDDEV = 1000._JPRD*SQRT(MAX((TIMESQSUM(JNUM)-TIMESUM(JNUM)**2/ICALLS)/(ICALLS-1),0.0_JPRD)) |
Collaborator
There was a problem hiding this comment.
Suggested change
| ZSTDDEV = 1000._JPRD*SQRT(MAX((TIMESQSUM(JNUM)-TIMESUM(JNUM)**2/ICALLS)/(ICALLS-1),0.0_JPRD)) | |
| ZSTDDEV = 1000._JPRD*SQRT(MAX((TIMESQSUM(JNUM)-TIMESUM(JNUM)**2/REAL(ICALLS,JPRD))/REAL(ICALLS-1,JPRD),0.0_JPRD)) |
Collaborator
|
It would be good to create a small test that creates such file. |
…avoid using CSVLINE
wdeconinck
force-pushed
the
feature/csv_output_1.6.1
branch
from
9d30246 to
ea3e217
Compare
- using gstats_setup.intfb.h - correct dimensions for kprcids - correct dimensions and type for avearray - make test work with and without MPI
wdeconinck
force-pushed
the
feature/csv_output_1.6.1
branch
from
ea3e217 to
936d8ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added to GSTATS an internal flag LCSV_STATS that is only true for LDETAILED_STATS that prints a csv file with timing and communication information per rank. The motivation is to have the raw recorded data to analyse and plot it more easily via e.g. pandas dataframes.
I will maybe later add some more recorded information to the csv file and also make LCSV_STATS an option to be set externally via the namelist but it is supposed to be always true per default for LDETAILED_STATS.