Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent multiple values conflict in FindExpressionRoot init #120

Closed
meteospike opened this issue Aug 2, 2023 · 1 comment · Fixed by #121
Closed

Prevent multiple values conflict in FindExpressionRoot init #120

meteospike opened this issue Aug 2, 2023 · 1 comment · Fixed by #121
Assignees
Labels
bug Something isn't working

Comments

@meteospike
Copy link

In module loki.expression.expr_visitors the initialization of class FindExpressionRoot does not check for unique keyword argument presence, which could lead to a multiple values conflict since this argument is statically set in the super.__init__ call.

This could be easily fixed, adding the line:
kwargs.pop('unique', None)

@reuterbal
Copy link
Collaborator

Thanks a lot for reporting, this is a genuine bug and I agree on the fix. I'll implement it now

@reuterbal reuterbal self-assigned this Aug 2, 2023
@reuterbal reuterbal added the bug Something isn't working label Aug 2, 2023
mlange05 added a commit that referenced this issue Aug 9, 2023
…nflict-in-findexpressionroot-init

Fix #120: Test and fix constructor arg conflict in FindExpressionRoot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants