Fix #120: Test and fix constructor arg conflict in FindExpressionRoot #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/121/index.html |
Codecov Report
@@ Coverage Diff @@
## main #121 +/- ##
==========================================
- Coverage 92.48% 92.15% -0.33%
==========================================
Files 14 90 +76
Lines 2355 16653 +14298
==========================================
+ Hits 2178 15347 +13169
- Misses 177 1306 +1129
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Not sure why codecov thinks that coverage went down |
mlange05
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Looks and nicely tested. Many thanks to @meteospike for reporting this. GTG from me.
|
Cool, overriding codecov and merging this. We might want to pin the codecov version number to prevent these, as the deviation is clearly not due to this branch. |
mlange05
deleted the
120-prevent-multiple-values-conflict-in-findexpressionroot-init
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.