Python 3.11 compatibility #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thon 3.11 Enum values do now have the type of mixin classes, which DataType is for BasicType. Consequently, instantiation fails and the class does not work in Python 3.11 and later. Some of that behaviour is also buggy, see the discussion in https://discuss.python.org/t/inconsistent-behavior-with-python-3-11-enum-mixin-class-behavior/24613/4 Removing the init routine restores the desired behaviour, although we do now no longer ensure that the base class has not been instantiated directly.
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/107/index.html |
reuterbal
force-pushed
the
69-python-3.11-compatibility
branch
from
b3f67be
to
62dd809
Compare
Codecov Report
@@ Coverage Diff @@
## main #107 +/- ##
=======================================
Coverage 92.14% 92.14%
=======================================
Files 89 89
Lines 16483 16482 -1
=======================================
Hits 15188 15188
+ Misses 1295 1294 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
reuterbal
force-pushed
the
69-python-3.11-compatibility
branch
from
62dd809
to
69b7053
Compare
This is due to PEP 663, which changed the string output to the basic integer value
mlange05
approved these changes
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change to achieve compatibility with Python 3.11. Reason is that since 3.11, Enum values do get the type of all mixin base classes and because of the composing nature how this is done, the assertion we had there triggered.
See also https://discuss.python.org/t/inconsistent-behavior-with-python-3-11-enum-mixin-class-behavior/24613/4
I had to also use a plain
Enumwithintdatatype instead ofIntEnumto retain the originalstr-behaviour. (Changed with PEP 663)Testing has been expanded to include Python 3.11